fix: score value race condition#244
Merged
Merged
Conversation
vabruzzo
changed the title
vabruzzo
changed the title
mkultraWasHere
pushed a commit
that referenced
this pull request
Dec 4, 2025
* bugfix score value race condition * revert agent change
briangreunke
added a commit
that referenced
this pull request
Dec 6, 2025
… file (#247) * chore(deps): update actions/checkout action to v6 (#238) | datasource | package | from | to | | ----------- | ---------------- | ------ | ------ | | github-tags | actions/checkout | v5.0.1 | v6.0.0 | Co-authored-by: dreadnode-renovate-bot[bot] <184170622+dreadnode-renovate-bot[bot]@users.noreply.github.com> * chore(deps): update pre-commit hook pycqa/bandit to v1.9.2 (#241) | datasource | package | from | to | | ----------- | ------------ | ----- | ----- | | github-tags | PyCQA/bandit | 1.9.1 | 1.9.2 | Co-authored-by: dreadnode-renovate-bot[bot] <184170622+dreadnode-renovate-bot[bot]@users.noreply.github.com> * chore(deps): update actions/setup-python action to v6.1.0 (#242) | datasource | package | from | to | | ----------- | -------------------- | ------ | ------ | | github-tags | actions/setup-python | v6.0.0 | v6.1.0 | Co-authored-by: dreadnode-renovate-bot[bot] <184170622+dreadnode-renovate-bot[bot]@users.noreply.github.com> * feat(user-data): Scope credentials fetch by organization and workspace (#232) * feat(project): add project key for identification and creation (#240) * feat(project): add project key for identification and creation * chore: updated docs * fix: score value race condition (#244) * bugfix score value race condition * revert agent change * fix: span duration property has inconsistent time formats (#245) * fix * fix --------- Co-authored-by: Michael Kouremetis <michael@Michaels-MacBook-Pro.local> * chore(deps): update actions/checkout action to v6.0.1 (#246) | datasource | package | from | to | | ----------- | ---------------- | ------ | ------ | | github-tags | actions/checkout | v6.0.0 | v6.0.1 | Co-authored-by: dreadnode-renovate-bot[bot] <184170622+dreadnode-renovate-bot[bot]@users.noreply.github.com> * feat(dataset): add push, save-to-disk, and refactor API --------- Co-authored-by: dreadnode-renovate-bot[bot] <184170622+dreadnode-renovate-bot[bot]@users.noreply.github.com> Co-authored-by: Vincent Abruzzo <6225496+vabruzzo@users.noreply.github.com> Co-authored-by: Michael Kouremetis <mkouremetis16@gmail.com> Co-authored-by: Michael Kouremetis <michael@Michaels-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix score_value stop condition race with concurrent trials
Key Changes:
Changed:
Bug Details:
When running with concurrency > 1, trials are added to the list in start order but complete out of order. The original code checked trials[-1] which could be a still-running trial when another trial completes.
Generated Summary:
stop.py, refined the logic to check for finished trials before proceeding, ensuring only completed trials are considered in the stopping criteria.This summary was generated with ❤️ by rigging